Conversation
trekhopton
approved these changes
May 28, 2025
saxon-milton
approved these changes
May 28, 2025
|
|
||
| // CameraSystem contains a camera device and the associated variables. | ||
| type CameraSystem struct { | ||
| Cam *model.Device |
Member
There was a problem hiding this comment.
Do these need to be exported ?
Member
Author
There was a problem hiding this comment.
I think so, because the caller will be returned a camera system which they will then be able to store (in a coming change) or for some reason may want to do some in between logic which would require these to be exported. They may want to for example get the mac address.
They don't necessarily need to be exported at the moment, but I don't see an issue with exporting them anyway?
ao-david
force-pushed
the
195-camera-var-defaults
branch
from
b45b70c to
f676417
Compare
ao-david
force-pushed
the
195-camera-autoconfig
branch
from
e117af1 to
c6d5bd5
Compare
This change adds a NewCamera function which creates the required camera and variables for a default camera setup.
This change adds tests for the NewCamera function
ao-david
force-pushed
the
195-camera-autoconfig
branch
from
c6d5bd5 to
8c88fe1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change helps to support camera autoconfig by creating a NewCamera with the required variables and settings.